Skip to content

PM-35112: feat: Add underlying FedRAMP environment#7138

Merged
david-livefront merged 1 commit into
mainfrom
PM-35112-fed-ramp-environment
Jul 6, 2026
Merged

PM-35112: feat: Add underlying FedRAMP environment#7138
david-livefront merged 1 commit into
mainfrom
PM-35112-fed-ramp-environment

Conversation

@david-livefront

@david-livefront david-livefront commented Jul 2, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-35112

📔 Objective

This PR adds the FedRAMP environment to the underlying structures of the app and integrates it into the LandingScreen UI.

The UI changes are currently feature flagged.

📸 Screenshots

Screen_recording_20260702_145555.mp4

@david-livefront
david-livefront requested a review from a team as a code owner July 2, 2026 19:56
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Jul 2, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of the FedRamp environment across the data layer (Environment, EnvironmentRegion, EnvironmentUrlDataJson, URL extensions), the restriction manager, and the LandingScreen/StartRegistration UI where selection is feature-flagged behind FlagKey.FedRamp. All when statements over EnvironmentRegion and Environment.Type were consistently updated, bitwarden-gov.com URLs follow the established per-region pattern, and account creation is correctly disabled for FedRAMP. Test coverage is comprehensive across data extensions, the restriction manager, and both ViewModels/screens. The prior KDoc copy-paste finding has been resolved.

No findings met the confidence threshold for posting.

Code Review Details

No blocking or actionable findings. Feature-flag wiring uses the standard internal-action pattern, non-exhaustive Environment usages elsewhere (PremiumStateManagerImpl, UserState) correctly treat FedRAMP as a hosted (non-self-hosted) environment, and the StartRegistration unconditional filter matches the "no account creation on FedRAMP" requirement.

@codecov

codecov Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.18%. Comparing base (200794c) to head (8d652d9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...epository/util/EnvironmentUrlDataJsonExtensions.kt 25.00% 6 Missing ⚠️
...i/auth/feature/environment/EnvironmentViewModel.kt 0.00% 0 Missing and 1 partial ⚠️
...warden/ui/auth/feature/landing/LandingViewModel.kt 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7138      +/-   ##
==========================================
- Coverage   86.76%   86.18%   -0.59%     
==========================================
  Files         868      882      +14     
  Lines       63939    64406     +467     
  Branches     9577     9588      +11     
==========================================
+ Hits        55479    55509      +30     
- Misses       5017     5454     +437     
  Partials     3443     3443
Flag Coverage Δ
app-data 17.59% <7.40%> (-0.01%) ⬇️
app-ui-auth-tools 18.80% <74.07%> (+0.02%) ⬆️
app-ui-platform 16.48% <1.85%> (-0.01%) ⬇️
app-ui-vault 27.50% <0.00%> (-0.02%) ⬇️
authenticator 6.15% <0.00%> (-0.03%) ⬇️
lib-core-network-bridge 4.07% <0.00%> (-0.02%) ⬇️
lib-data-ui 1.14% <3.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront
david-livefront force-pushed the PM-35112-fed-ramp-environment branch 2 times, most recently from dda6cee to b513bcb Compare July 2, 2026 20:16
@david-livefront
david-livefront force-pushed the PM-35112-fed-ramp-environment branch from b513bcb to 8d652d9 Compare July 6, 2026 14:20
aj-rosado
aj-rosado approved these changes Jul 6, 2026
View reviewed changes

@aj-rosado aj-rosado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@david-livefront

david-livefront commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks @aj-rosado

@david-livefront
david-livefront added this pull request to the merge queue Jul 6, 2026
Merged via the queue into main with commit 6ea0afb Jul 6, 2026
23 checks passed
@david-livefront
david-livefront deleted the PM-35112-fed-ramp-environment branch July 6, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@aj-rosado aj-rosado aj-rosado approved these changes
@SaintPatrck SaintPatrck Awaiting requested review from SaintPatrck
@vvolkgang vvolkgang Awaiting requested review from vvolkgang

Assignees

No one assigned

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@david-livefront @aj-rosado